Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(risedevtool): try download kafka from archive.apache if downloads.apache does not work #10414

Merged
merged 2 commits into from
Jun 19, 2023
Merged

fix(risedevtool): try download kafka from archive.apache if downloads.apache does not work #10414

merged 2 commits into from
Jun 19, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Jun 19, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Cherry pick #10411

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@kwannoel kwannoel changed the base branch from main to v0.19.0-rc June 19, 2023 12:03
@kwannoel kwannoel requested a review from lmatz June 19, 2023 12:03
@github-actions github-actions bot added type/fix Bug fix user-facing-changes Contains changes that are visible to users labels Jun 19, 2023
@lmatz lmatz enabled auto-merge (squash) June 19, 2023 12:23
@lmatz lmatz merged commit 767cb48 into v0.19.0-rc Jun 19, 2023
@lmatz lmatz deleted the kwannoel/fix-kafka-dl-url branch June 19, 2023 12:28
@kwannoel kwannoel added user-facing-changes Contains changes that are visible to users and removed user-facing-changes Contains changes that are visible to users labels Jun 20, 2023
@CharlieSYH CharlieSYH added the 📖✗ No user documentation is needed. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmatz lmatz lmatz approved these changes

Assignees
No one assigned
Labels
type/fix Bug fix user-facing-changes Contains changes that are visible to users 📖✗ No user documentation is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwannoel @lmatz @CharlieSYH